[WIP] Add test simulating unreachable socket for reporter#82
Open
[WIP] Add test simulating unreachable socket for reporter#82
Conversation
Contributor
|
@justinjc your test isn't simulating conditions properly: Processor thread is continues to run in the thread dump of your first test-run: |
Collaborator
|
The same thread you're pointing out continues to run in the second test as well: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test sets up:
The scenario:
Observations when run on git ref:
978287b: timers are recorded, then after the socket is closed, timers continue to be recorded.
SocketCloseTest)3280651: timers are recorded, then after the socket is closed, timers are blocked from being recorded.
SocketCloseTest)0589dcc (the latest 0.9.0 release): timers are recorded, then after the socket is closed, timers continue to be recorded.
SocketCloseTest)